TypeScript fixes #95
Open
TypeScript fixes #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-north
commented
Oct 30, 2018
| @@ -49,9 +52,9 @@ | |||
| "rollup-plugin-commonjs": "^9.1.6", | |||
| "rollup-plugin-node-resolve": "^3.4.0", | |||
| "rollup-plugin-replace": "^2.0.0", | |||
| "rollup-plugin-typescript": "^0.8.1", | |||
| "rollup-plugin-typescript2": "^0.17.2", | |||
There was a problem hiding this comment.
mike-north
commented
Oct 30, 2018
| @@ -19,6 +19,6 @@ describe('CounterStore', function() { | |||
| _namespaceCount: 0, | |||
| _nameCache: {}, | |||
| _labelCache: {} | |||
There was a problem hiding this comment.
the properties above are private, in the CounterStore class. As long as they're not public, this POJO will never be type-equivalent to a CounterStore or Partial<CounterStore>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it turns out that the official typescript rollup plugin doesn't actually type-check, since it analyzes each file in isolation instead of a wholistic analysis of the entire project.
as a result of this, there are a bunch of TS errors that should probably be fixed. this is not complete, but a good start at tackling the ones that are fairly obvious without much context around the library