warn if a mismatched global session is present (fix #47) #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // The name of the property encodes the session/node compatibilty version | ||
| if (!global._heimdall_session_3) { | ||
| global._heimdall_session_3 = new Session(); | ||
| } | ||
|
|
||
| for (let i = 1; i < 3; i++) { |
There was a problem hiding this comment.
Might be unnecessary, but we could do const CURRENT_VERSION = 3; in the module scope and replace 3 everywhere with the constant so that future upgrades are easy.
There was a problem hiding this comment.
Agree, makes what's going on here more intuitive.
There was a problem hiding this comment.
Basic approach seems fine although TBH i think it would be clearer to just unroll the loop. We really don't plan on bumping the session version often.
if ('_heimdall_session_1' in global || '_heimdall_session_2' in global) {
//warn
}Also tests.
stefanpenner
requested changes
Dec 19, 2016
| global[CURRENT_SESSION_KEY] = new Session(); | ||
| } | ||
|
|
||
| for (let i = 1; i < CURRENT_VERSION; i++) { |
|
This may have gone stale, do we want this still? |
|
@stefanpenner i think we do; it should be an indication to upgrade certain deps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.