fix(auth): Fix session data loss by redirect #4483
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch should fix the broken redirect behaviour of the authentication provider where users aren't redirected back to the note they were send off, due to passport forgetting its session. Reference: jaredhanson/passport#919 Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
Mhm, after some reading with the help of @ErikMichelson it might not be ideal to use this. It becomes a potential security issue for shared computers (libraries, schools, …). I guess we rather wait for the upstream fix to land: |
ErikMichelson
added
the
status: blocked by upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component/Part
authentication
Description
This patch should fix the broken redirect behaviour of the authentication provider where users aren't redirected back to the note they were send off, due to passport forgetting its session.
Steps
made sure that:
masterfor 1.x & docs,developfor 2.xRelated Issue(s)
jaredhanson/passport#919