Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support react-sketchapp #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

karlsander
Copy link

This is not a polished PR intended to be merged but just the quick fork I made for myself. I created the PR to ask how interested you are in adding this. I would be willing to work on a more serious solution too. For now I:

  • changed react-native to react-primitives so StyleSheet.create and Platform can work: seems like a decent solution but adding a dependency to this otherwise dependency free project is not so great. Maybe people usually cover this with webpack aliasing in their react-sketchapp setups anyway? How is it handled for react-native-web?
  • copied all the .ios.js files to .sketch.js files: likely not exactly the right solution but close enough for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants