Drop support to EOL rubies and Rails #5600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
force-pushed
the
rm-drop-support-to-old-rubies-and-rails
branch
2 times, most recently
from
71b0468
to
a231897
Compare
RailsCod3rFuture
approved these changes
Jun 10, 2023
This was referenced Sep 12, 2023
All Ruby 2.x are EOL now.
It's EOL but the current versions of Rails are still supporting it, so it makes sense for us to keep supporting it as well. And it doesn't give us any extra maintenance burden as older versions have been doing.
carlosantoniodasilva
force-pushed
the
rm-drop-support-to-old-rubies-and-rails
branch
from
a231897
to
72b421e
Compare
Also change back to run CI on ubuntu-latest which should work with all Ruby versions supported now.
They were added to support an old/deprecated feature of Rails, as the message was saying, we can now remove them from the code as well.
|
Thanks @rafaelfranca! I was hesitant to drop support and have to go to a 5x release, but it's probably time, there's a few other potential breaking changes we can then include to move things forward. I've branched out a |
carlosantoniodasilva
deleted the
rm-drop-support-to-old-rubies-and-rails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@carlosantoniodasilva I'm not sure if you were keeping support to those old versions by design, but maybe it is time for us to let it go. All tests on Ruby < 2.7 were failing.