View helper methods #5493
Open
View helper methods #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marivaldo
reviewed
May 22, 2022
| class ViewsHelperMethodsTest < Devise::IntegrationTest | ||
|
|
||
| test 'Action View includes Devise::Views::Helpers' do | ||
| assert_includes ActionView.ancestors, Devise::Views::Helpers |
There was a problem hiding this comment.
Suggested change
| assert_includes ActionView.ancestors, Devise::Views::Helpers | |
| assert_includes ActionView.ancestors, Devise::Views::Helpers |
There was a problem hiding this comment.
Thank you for the review. Could we get this pull request submitted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If/Else conditional statements based on a users session status are relatively common at the controller and view level of applications. These conditional statements are repetitive, accumulate quickly and make our code bulky . Great programs are DRY and this pull request seeks to DRY up our code by creating helper methods that abstract if/else conditionals into methods where a block is called based on a resources sign_in/out state.
Examples:
View ->
user_signed_out do <%= link_to "Sign In", new_user_session_path %> endController ->
def some_action; admin_signed_in { render @posts }; admin_signed_out { redirect_to root_path }; end