Up-for-discussion: change node-imagemagick dependency to GM + more #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filenameId allows the user to customize the filename. Before: /dir/objectId-original.jpg Now: /dir/<custom-model-attribute>-original.jog
Conflicts: lib/attachments.js
This reverts commit fa5b4bf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes breaking changes. So I'm happy to maintain this as a separate
project if need be (or if this project is dead and no one responds here).
Otherwise it should probably go into a major release branch.
Backwards-breaking:
makes good use of the GM api.
GM but it seems redundant to me...
Reasoning behind the change to GM is because node-imagemagick is no longer
maintained (nor is the 'new' maintained version) and GM is still very active so
definitely where it's at. In the long term I think a move to GM would be
inevitable for anyone who wants to continue using this library. I already ran
into an edge-case issue with
node-imagick that caused the whole server to crash.
Note, when I say GM I mean this node library which also supports imagemagick