Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolchain: add symbiflow-toolchain package #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acomodi
Copy link
Contributor

@acomodi acomodi commented Nov 30, 2021

Signed-off-by: Alessandro Comodi acomodi@antmicro.com

This supersedes #48, and adds the symbiflow toolchain package


mkdir -p $PREFIX

curl -s https://storage.googleapis.com/symbiflow-arch-defs-gha/symbiflow-toolchain-latest | xargs wget -qO- | tar -xJC $PREFIX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to make sure that there is a connection between these assets and the symbiflow-arch-defs git revision and not use the random latest version....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this needs to download the results which match the git revision used to generate the package metadata. That info should be available in the shell environment somewhere...

@PiotrZierhoffer
Copy link
Contributor

As we've been discussing this internally, our current approach is to:

  • have a separate CI flow that checks the latest revision and rebuilds the package with the same revision name
  • have the package listed explicitly in target project's environment

This PR is a stub we begin with, based on the work we started ~1 year ago

@mithro
Copy link
Member

mithro commented Dec 1, 2021

Is there a simple way to go from symbiflow-arch-defs git revision number to the build CI output?

If so, you could use that process so that the contents are determined by the symbiflow-arch-defs git revision the package is built with?

@acomodi
Copy link
Contributor Author

acomodi commented Dec 1, 2021

Actually the git revision number is present within the link contained in https://storage.googleapis.com/symbiflow-arch-defs-gha/symbiflow-toolchain-latest.

For instance, the current latest link is the following:

https://www.googleapis.com/download/storage/v1/b/symbiflow-arch-defs/o/artifacts%2Fprod%2Ffoss-fpga-tools%2Fsymbiflow-arch-defs%2Fcontinuous%2Finstall%2F474%2F20211130-000503%2Fsymbiflow-arch-defs-install-8842ce79.tar.xz?generation=1638277014446946&alt=media

Where 8842ce79 is the sha of the most recent commit that generated the arch files in arch-defs: f4pga/f4pga-arch-defs@8842ce7.

The above link also contains the build date, so we may probably extract that as well from there.

Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
@mithro
Copy link
Member

mithro commented Dec 1, 2021

Actually the git revision number is present within the link contained in https://storage.googleapis.com/symbiflow-arch-defs-gha/symbiflow-toolchain-latest.

For instance, the current latest link is the following:

https://www.googleapis.com/download/storage/v1/b/symbiflow-arch-defs/o/artifacts%2Fprod%2Ffoss-fpga-tools%2Fsymbiflow-arch-defs%2Fcontinuous%2Finstall%2F474%2F20211130-000503%2Fsymbiflow-arch-defs-install-8842ce79.tar.xz?generation=1638277014446946&alt=media

Where 8842ce79 is the sha of the most recent commit that generated the arch files in arch-defs: SymbiFlow/symbiflow-arch-defs@8842ce7.

The above link also contains the build date, so we may probably extract that as well from there.

That is the wrong way around. You want to go from git revision ID to a build result (not from a build result to a git revision ID).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants