Merge pull request #1109 from hcoles/feature/relax_filename_checl

Relax source file attribute check
hcoles · Nov 11, 2022 · f043493 · f043493
2 parents d151089 + 347dde1
commit f043493
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 11 deletions.
diff --git a/pitest-entry/src/main/java/org/pitest/mutationtest/verify/DefaultBuildVerifier.java b/pitest-entry/src/main/java/org/pitest/mutationtest/verify/DefaultBuildVerifier.java
@@ -16,7 +16,7 @@
  */
 
 import java.util.Collection;
-import java.util.function.Consumer;
+import java.util.List;
 import java.util.function.Predicate;
 
 import org.pitest.classinfo.ClassInfo;
@@ -29,11 +29,11 @@ public class DefaultBuildVerifier implements BuildVerifier {
 
   @Override
   public void verify(final CodeSource code) {
-    final Collection<ClassInfo> codeClasses = FCollection.filter(code.getCode(), isNotSynthetic());
+    final List<ClassInfo> codeClasses = FCollection.filter(code.getCode(), isNotSynthetic());
 
     if (hasMutableCode(codeClasses)) {
       checkAtLeastOneClassHasLineNumbers(codeClasses);
-      codeClasses.forEach(throwErrorIfHasNoSourceFile());
+      checkAtLeastOneClassHasSourceFile(codeClasses);
     }
   }
 
@@ -54,6 +54,14 @@ private void checkAtLeastOneClassHasLineNumbers(
     }
   }
 
+  private void checkAtLeastOneClassHasSourceFile(List<ClassInfo> codeClasses) {
+    // perform only a weak check for line numbers as
+    // some jvm languages are not guaranteed to include a source file for all classes
+    if (!FCollection.contains(codeClasses, a -> a.getSourceFileName() != null)) {
+      throw new PitHelpError(Help.NO_SOURCE_FILE, codeClasses.get(0).getName().asJavaName());
+    }
+  }
+
   private static Predicate<ClassInfo> aConcreteClass() {
     return a -> !a.isInterface();
   }
@@ -62,14 +70,6 @@ private static Predicate<ClassInfo> aClassWithLineNumbers() {
     return a -> a.getNumberOfCodeLines() != 0;
   }
 
-  private Consumer<ClassInfo> throwErrorIfHasNoSourceFile() {
-    return a -> {
-      if (a.getSourceFileName() == null) {
-        throw new PitHelpError(Help.NO_SOURCE_FILE, a.getName().asJavaName());
-      }
-    };
-  }
-
   private static Predicate<ClassInfo> isNotSynthetic() {
     return a -> !a.isSynthetic();
   }

diff --git a/pitest-entry/src/test/java/org/pitest/mutationtest/verify/DefaultBuildVerifierTest.java b/pitest-entry/src/test/java/org/pitest/mutationtest/verify/DefaultBuildVerifierTest.java
@@ -15,6 +15,7 @@
 
 package org.pitest.mutationtest.verify;
 
+import static org.assertj.core.api.Assertions.assertThatCode;
 import static org.junit.Assert.fail;
 import static org.mockito.Mockito.when;
 
@@ -105,6 +106,12 @@ public void shouldNotThrowAnErrorWhenOnlyInterfacesPresent() {
     }
   }
 
+  @Test
+  public void doesNotErrorWhenNoClassesProvided() {
+    when(this.code.getCode()).thenReturn(Collections.emptyList());
+    assertThatCode(() -> this.testee.verify(this.code)).doesNotThrowAnyException();
+  }
+
   private void setupClassPath(final Class<?> clazz) {
     this.setupClassPath(
         new ClassloaderByteArraySource(IsolationUtils.getContextClassLoader()),