updated logging to lazy version and replaced format by f-string for BleakClientWinRT #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
reviewed
Sep 12, 2022
jochenjagers
force-pushed
the
bugfix/cleanup_logging_of_winrt_client
branch
from
03570ec
to
fa6bd43
Compare
jochenjagers
force-pushed
the
bugfix/cleanup_logging_of_winrt_client
branch
from
fa6bd43
to
9a0264e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR updates the BleakClientWinRT to use f-strings instead of .format function and lazy formatting for logger calls.
It also removes the _pairing_statuses and _unpairing_statuses objects which contained a bit strange subset of the corresponding enums but skipping all values that contain an underscore. Instead of them DevicePairingResultStatus(value).name is used for logging the values.