Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
mocha
simport("mocha/lib/cli/options").loadOptions
function does not respect theextends
setting.Rather, config inheritance is handled separately in
mocha/lib/cli/cli
:https://github.com/mochajs/mocha/blob/37deed262d4bc0788d32c66636495d10038ad398/lib/cli/cli.js#L49-L79
Notice the
import("yargs").config()
call in the linked snippet.To address this issue, changes to
loadConfig
have been made to replicatemocha
s behavior:https://github.com/manuth/vscode-mocha-test-adapter/blob/aa7ec47884ffb8c82885ee7c1942bbecd6596056/src/worker/loadConfig.ts#L4-L12
Changes made in this PR will fix #223