Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try...catch.. for processTaskQueue per https://github.com/hazelcast/hazelcast/issues/26290 #26311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cnlzhang
Copy link

@cnlzhang cnlzhang commented Apr 12, 2024

Hi there,
We have faced this NullPointer issue and submitted our fix, any admins pls have a look

@hz-devops-test hz-devops-test added the Source: Community PR or issue was opened by a community user label Apr 12, 2024
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@devOpsHazelcast
Copy link
Collaborator

Internal PR hazelcast/hazelcast-mono#1357
Internal message only. Nothing to see here, move along

@JackPGreen
Copy link
Contributor

Hi - thanks for your contribution.

Are you able to add any test cases for where this problem occurs?

Just wondering if a try / catch is the best solution for this issue?

@cnlzhang
Copy link
Author

cnlzhang commented Apr 16, 2024

Hi - thanks for your contribution.

Are you able to add any test cases for where this problem occurs?

Just wondering if a try / catch is the best solution for this issue?

Hi,
Thanks for your reply!
I think i have faced same issue with this one #17672
since when startMigration, it will set both selectionKey and owner to null
selectionKey = null;
owner = null;
while in my case, this NPE exception happend in PublishAllTask
image
Sorry for this simple and easy look fix, i submitted this issue but found no response
So i think add a simple try...catch... to control this NPE's disastrous effect
AND i also try to add some test case but found no exist for this PublishAllTask, i will work on this and update later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source: Community PR or issue was opened by a community user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants