isAsync takes precedence over OperationHostileThread

[lukasherman]

Fixes #24712
OperationExecutor allows async invocation of OperationHostileThread.

[devOpsHazelcast]

Can one of the admins verify this patch?

[devOpsHazelcast]

All committers have signed the CLA.

[devOpsHazelcast]

Can one of the admins verify this patch?

[devOpsHazelcast]

Can one of the admins verify this patch?

[devOpsHazelcast]

Internal PR hazelcast/hazelcast-mono#484
Internal message only. Nothing to see here, move along

[TomaszGaweda]

@vbekiaris can you please take a look?

[JamesHazelcast]

Thanks for submitting this contribution. I don't see any obvious downsides to this change, but the interface OperationHostileThread suggests that these threads should never be used to run Operations, in which case it makes sense to disallow running Operations on these threads, even if called async.

As I'm not familiar with OperationHostileThread and its exact usage, I'll call in the expert @pveentjer for his review of this change.

[pveentjer]

The purpose of OperationHostileThread is to prevent any operation running on that thread. For partition-specific operations, it is obvious that you need to run on a partition-thread, but there are also operations that do not require a partition thread to run on. We need to make sure that such operations don't get executed on such an OperationHostileThread (e.g. an IO-thread).

[pveentjer]

The change is fine since with 'async' the actual operation execution will always be offloaded to the right thread and will never be executed on an OperationHostileThread.

[JamesHazelcast]

Thanks for the contribution @lukasherman, we appreciate it!

[zjedi]

any chance for backporting the fix to 5.3 branch?

[JamesHazelcast]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Lukáš Herman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Please sign the CLA so we can proceed @lukasherman.

[lukasherman]

Please sign the CLA so we can proceed @lukasherman.

I have signed it several times already, please check.

[devOpsHazelcast]

This pull request has been closed because it was already merged as https://github.com/hazelcast/hazelcast-mono/pull/484

[JamesHazelcast]

any chance for backporting the fix to 5.3 branch?

This will be backported to our 5.3.z branch, yes 👍