Fix testNullValuesFromMapLoaderAreNotInsertedIntoMap failure

[alyokaz]

Fixes failure to throw a NullPointerException when a null value from a MapLoader is inserted into a Map.

The issue appears to been have introduced in commit 7ec4749 in which the null value is chosen to be tolerated as normal rather then exceptional.

I've reused the code DefaultRecordStore as this was the check in the original flow of the code. The partitionId check is superfluous here, however.

Fixes #26184

[devOpsHazelcast]

All committers have signed the CLA.

[devOpsHazelcast]

Can one of the admins verify this patch?

[devOpsHazelcast]

Can one of the admins verify this patch?

[devOpsHazelcast]

Can one of the admins verify this patch?

[devOpsHazelcast]

Internal PR hazelcast/hazelcast-mono#359
Internal message only. Nothing to see here, move along

[vbekiaris]

@alyokaz thanks for the pull request! @ahmetmircik can you please have a look?

[alyokaz]

Just wanted to point out that the Refactor deals with null values being added by passing over them and not adding them to the map both when a key has a null value and in the case of a non-existent key. This is why the NPE wasn't being thrown, however, the fix will be over-zealous in the latter case and should probably be made conditional on the existence of the key if we want to allow for both behaviours.

[alyokaz]

Thinking about this further, the fix does fulfil the IMap.loadAll() contract that an NPE should be thrown if any key or value returned by MapLoader.loadAll() is null. However, this might be considered inconsistent with the behaviour of get() witch returns null if the the key does not exist as opposed to throwing an NPE. getAll() calls loadAll() and so an NPE is thrown there as well.

[ahmetmircik]

Hi, just have a look at this.

IMap#getAll behavior in master branch is inline with vanilla IMap#get, while they never let null values, they also don’t throw NPE exception when map-loader has no matching value for a key. We need to fix the test code, getAll’s implementation code seems ok.
So to recap, IMap#getAll only returns matching values and when there is no matching value, it silently ignores it as in ICache#getAll.

[devOpsHazelcast]

This pull request has been closed because it was already closed as https://github.com/hazelcast/hazelcast-mono/pull/359