Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate junit version in ClientTpcConfigTest and HazelcastOSGiIT te… #26196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Integrate junit version in ClientTpcConfigTest and HazelcastOSGiIT te… #26196

wants to merge 1 commit into from

Conversation

mohyazdanpanah
Copy link

@mohyazdanpanah mohyazdanpanah commented Dec 23, 2023 •
edited

Fixes (#26193)

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Not Release Notes content
  • Request reviewers if possible
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc
  • Send backports/forwardports if fix needs to be applied to past/future releases

@hz-devops-test hz-devops-test added the Source: Community PR or issue was opened by a community user label Dec 23, 2023
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

devOpsHazelcast commented Dec 23, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Internal PR hazelcast/hazelcast-mono#285
Internal message only. Nothing to see here, move along

@JackPGreen
Copy link
Contributor

@mohyazdanpanah thanks for your contribution!

It's great you've addressed these issues - had you considered amending the test referenced in #26193 to see if further examples could be caught going forwards?

@mohyazdanpanah
Copy link
Author

mohyazdanpanah commented Dec 26, 2023 •
edited

@JackPGreen Your Welcome
I just fix classes which you mentioned in the issue. I will fix them all if changes don’t broke anything. Thank you!

@devOpsHazelcast
Copy link
Collaborator

This pull request has been closed because it was already closed as https://github.com/hazelcast/hazelcast-mono/pull/285

@JackPGreen JackPGreen reopened this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackPGreen JackPGreen JackPGreen approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Source: Community PR or issue was opened by a community user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mohyazdanpanah @devOpsHazelcast @JackPGreen @hz-devops-test