Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated StringUtil::trim() to consider all type of whilte space #25804

Closed
wants to merge 1 commit into from
Closed

Updated StringUtil::trim() to consider all type of whilte space #25804

wants to merge 1 commit into from

Conversation

Gauravsalunke5
Copy link
Contributor

Fixes #25519

@hz-devops-test hz-devops-test added the Source: Community PR or issue was opened by a community user label Oct 23, 2023
@devOpsHazelcast
Copy link
Collaborator

devOpsHazelcast commented Oct 23, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

3 similar comments
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@Gauravsalunke5 Gauravsalunke5 mentioned this pull request Oct 23, 2023
Closed
@JackPGreen
Copy link
Contributor

@Gauravsalunke5 thanks for your contribution!

Besides the change to the method, have you considered some of the other suggestions from the original issue?

Specifically about updating the Javadoc and adding test coverage.

@Gauravsalunke5
Copy link
Contributor Author

@JackPGreen added test cases and updated Javadoc for the same

@JackPGreen
Copy link
Contributor

run-lab-run

@hz-devops-test
Copy link

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file 
---------ERRORS-----------
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/internal/util/StringUtilTest.java:224: Line has trailing spaces. [RegexpSingleline]
--------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.0:checkstyle (default) on project hazelcast: An error has occurred in Checkstyle report generation. Failed during checkstyle execution: There is 1 error reported by Checkstyle 9.3 with /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/checkstyle/checkstyle.xml ruleset. -> [Help 1]
--------------------------
[ERROR] 
--------------------------
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
--------------------------
[ERROR] 
--------------------------
[ERROR] For more information about the errors and possible solutions, please read the following articles:
--------------------------
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
--------------------------
[ERROR] 
--------------------------
[ERROR] After correcting the problems, you can resume the build with the command
--------------------------
[ERROR]   mvn  -rf :hazelcast
--------------------------

@JackPGreen
Copy link
Contributor

run-lab-run

@Gauravsalunke5
Copy link
Contributor Author

Gauravsalunke5 commented Oct 26, 2023 •
edited

@JackPGreen Anything left to add in PR ?

@JackPGreen
Copy link
Contributor

@JackPGreen Anything left to add in PR ?

just awaiting a second reviewer :)

@Gauravsalunke5
Copy link
Contributor Author

@vbekiaris @JamesHazelcast @Edizc can anyone review and merge the code?

@Gauravsalunke5
Copy link
Contributor Author

Gauravsalunke5 commented Mar 14, 2024 •
edited

@devOpsHazelcast @hz-devops-test

@JamesHazelcast JamesHazelcast self-requested a review March 14, 2024 16:05
@JamesHazelcast JamesHazelcast added this to the 5.5.0 milestone Mar 14, 2024
@JamesHazelcast
Copy link
Contributor

Thanks for this contribution @Gauravsalunke5, apologies for the delay in getting it approved - we've changed our internal process recently and we're playing a bit of catch up with some PRs!

@devOpsHazelcast
Copy link
Collaborator

Internal PR hazelcast/hazelcast-mono#1131
Internal message only. Nothing to see here, move along

devOpsHazelcast pushed a commit that referenced this pull request Mar 15, 2024
@Gauravsalunke5 @actions-user
Updated StringUtil::trim() to consider all types of white space (#1131)
f7dd26c 
Import of #25804

**Original PR description:**

Fixes #25519

Imported changes:

- 1842540 Updated StringUtil::trim() to
consider all type of whilte...

Closes #25804

Co-authored-by: Gaurav Salunke <gauravsalunke15@gmail.com>
GitOrigin-RevId: a49c5c13ac4307561afe1b5432cbb91340e05d64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackPGreen JackPGreen JackPGreen approved these changes

@JamesHazelcast JamesHazelcast Awaiting requested review from JamesHazelcast

Assignees
No one assigned
Labels
Not Release Notes content Priority: Low Source: Community PR or issue was opened by a community user Type: Defect
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

StringUtil.trim(String) implementation doesn't match Javadoc contract
6 participants
@Gauravsalunke5 @devOpsHazelcast @JackPGreen @hz-devops-test @JamesHazelcast @ldziedziul