Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close leaking streams using try-with-resources in tests -2 [HZ-3391] #25617

Merged
merged 7 commits into from Oct 9, 2023
Merged

Close leaking streams using try-with-resources in tests -2 [HZ-3391] #25617

merged 7 commits into from Oct 9, 2023

Conversation

orcunc
Copy link
Contributor

@orcunc orcunc commented Oct 5, 2023 •
edited

The first fix is here
#25593

Client protocol generator PR is
hazelcast/hazelcast-client-protocol#479

This is the second round of fixes.

Jira : https://hazelcast.atlassian.net/browse/HZ-3391
Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible

@orcunc orcunc added this to the 5.4.0 milestone Oct 5, 2023
@orcunc orcunc self-assigned this Oct 5, 2023
@orcunc orcunc changed the title Close leaking streams using try-with-resources in tests [HZ-3391] Close leaking streams using try-with-resources in tests -2 [HZ-3391] Oct 5, 2023
JackPGreen
JackPGreen requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@JackPGreen JackPGreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm totally happy with the changes you've made, but I think if were changing them we could probably change them a different way that's nicer?

hazelcast/src/main/java/com/hazelcast/gcp/GcpAuthenticator.java Outdated Show resolved Hide resolved
...test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityNullTest_2_0_1.java Outdated Show resolved Hide resolved
...test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityNullTest_2_0_1.java Show resolved Hide resolved
JamesHazelcast
JamesHazelcast approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@JamesHazelcast JamesHazelcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these leaks @orcunc! 🔧

@orcunc orcunc marked this pull request as ready for review October 9, 2023 07:43
@orcunc orcunc requested review from a team as code owners October 9, 2023 07:43
kwart
kwart approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@kwart kwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 SWG approval for MessageTaskSecurityTest.java

@orcunc orcunc merged commit 2688200 into hazelcast:master Oct 9, 2023
8 checks passed
@orcunc orcunc deleted the fix/5.4/hz-3391-fix-leaks branch October 9, 2023 11:00
@orcunc orcunc mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwart kwart kwart approved these changes

@JackPGreen JackPGreen JackPGreen approved these changes

@srknzl srknzl srknzl approved these changes

@k-jamroz k-jamroz k-jamroz approved these changes

@JamesHazelcast JamesHazelcast JamesHazelcast approved these changes

Assignees

@orcunc orcunc

Labels
Not Release Notes content Source: Internal PR or issue was opened by an employee Team: Integration Type: Cleanup
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@orcunc @kwart @JackPGreen @srknzl @k-jamroz @JamesHazelcast