Disable license plugin by default #24742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frant-hartm
added
[OLD]Team: Integration
Type: Cleanup
Source: Internal
frant-hartm
force-pushed
the
cleanup/5.4/disable-license-plugin
branch
from
eb7d1fb
to
36afbdf
Compare
TomaszGaweda
approved these changes
Jun 6, 2023
kwart
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
LGTM. We should revert this once the related plugin fix mojohaus/license-maven-plugin#474 is released.
Merged
JackPGreen
added a commit
that referenced
this pull request
Aug 29, 2023
The `org.reactivestreams:reactive-streams:1.0.4` transitive dependency uses an [MIT-0 licence](https://spdx.org/licenses/MIT-0.html), which was not specifically allowed in the `license-maven-plugin` configuration. `reactive-streams` has been on [MIT-0 for a long time](reactive-streams/reactive-streams-jvm@006202e), but only since #25284 - where the `S3` client was updated to use new `reactive-streams` - has this become a problem. This caused intermittent failures of the PR builder. This intermittency was presumably caused by the fact that the licence check [was recently turned off](#24742) by default for performance reasons (see comments on the `license.skipAddThirdParty` property). Although the original PR builder execution failed the first time with this error, the second time it passed and was merged - and then caused more PR builder execution failures on other, unrelated PRs. Unfortunately I don't have a solution on how to prevent this problem in future. As MIT-0 is a less restrictive version of the MIT licence (which is included), so I've included this also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release NotesorNot Release Notes contentset