DiscoveryJoiner was using WAIT_SECONDS_BEFORE_JOIN where MAX_WAIT_SECONDS_BEFORE_JOIN was meant
#23083
Conversation
…T_SECONDS_BEFORE_JOIN` was meant
hz-devops-test
added
the
Source: Community
|
Can one of the admins verify this patch? |
11 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
|
|
I believe this remains valid. However
is not possible since I lack permission to reopen. Help @frant-hartm as last committer? |
| @@ -49,7 +49,7 @@ public class DiscoveryJoiner | |||
|
|
|||
| public DiscoveryJoiner(Node node, DiscoveryService discoveryService, boolean usePublicAddress) { | |||
| super(node); | |||
| this.maximumWaitingTimeBeforeJoinSeconds = node.getProperties().getInteger(WAIT_SECONDS_BEFORE_JOIN); | |||
| this.maximumWaitingTimeBeforeJoinSeconds = node.getProperties().getInteger(MAX_WAIT_SECONDS_BEFORE_JOIN); | |||
There was a problem hiding this comment.
hello @jglick 👋
My memory is hazy about this particular change, but I reckon that if you change this field to use MAX_WAIT_SECONDS_BEFORE_JOIN then it will increase the initial startup time from +-5s to +-20s for any discovery strategy except UDP and static TCPs. That's probably not what you want. I agree the field name is misleading, it should have been called just "waitingTimeBeforeJoinSeconds` or so.
There was a problem hiding this comment.
Čau! #23083 (comment) since that was previously hidden. If the code here is intentional, I suppose at least a comment is in order? (Understood that this was years ago.)
There was a problem hiding this comment.
I tend to agree that the field has been mis-named here and would keep the WAIT_SECONDS_BEFORE_JOIN property. @hasancelik wdyt?
This comment was marked as outdated.
This comment was marked as outdated.
|
@jglick I reopened the PR and restored the original description (apologies on behalf of our bot , it should not misbehave like that in the future). |
|
run-lab-run |
|
PR closed by Hazelcast automation as no activity (>6 months). Please reopen with comments, if necessary. Thank you for using Hazelcast and your valuable contributions |
For example
hazelcast/hazelcast/src/main/java/com/hazelcast/internal/cluster/impl/ClusterJoinManager.java
Line 135 in 128f546
looks right but here the variable was not named with max so I suspect this was simply a typo at some point.
Observed while experimenting with a custom
DiscoveryStrategywhosestartmethod was getting called butdiscoverNodeswas not. In a debugger I tracked this down toDiscoveryJoiner.getPossibleAddressesForInitialJoinskipping the call togetPossibleAddresses. The problem disappeared when I removedNo idea how this sort of thing would be tested, sorry.