New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description to JobConfig #21489
base: master
Are you sure you want to change the base?
Add description to JobConfig #21489
Conversation
Can one of the admins verify this patch? |
10 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
run-lab-run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately we can't do changes to binary format of JobConfig
. The class must be backwards compatible because it's stored as a part of JobRecord
and a cluster must be able to deserialize it after a rolling upgrade. It also can't use Versioned
, because it's also sent in binary form from the client (see #20755). Therefore we can't do incompatible changes until the next major release.
@viliam-durina |
@awelless Is there any chance you could join our community Slack channel ? -- there's a link to do so here https://hazelcast.com/dev-community/. |
This can be achieved currently by using |
I'll add a comment to #20510 discussing the motivation. This fix seems pretty good, perhaps the wider problem is that Jet config does not support easy extension as new fields are required |
PR closed by Hazelcast automation as no activity (>6 months). Please reopen with comments, if necessary. Thank you for using Hazelcast and your valuable contributions |
The job Click to expand the log file---------ERRORS----------- -------------------------- [ERROR] Error executing Maven. -------------------------- |
Being able to describe jobs using a description field remains a useful need. |
Added description to a JobConfig according to the following issue: #20510