Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to JobConfig #21489

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

awelless
Copy link

Added description to a JobConfig according to the following issue: #20510

@hz-devops-test hz-devops-test added the Source: Community PR or issue was opened by a community user label May 29, 2022
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

10 similar comments
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

devOpsHazelcast commented May 29, 2022

CLA assistant check
All committers have signed the CLA.

@TomaszGaweda
Copy link
Contributor

run-lab-run

Copy link
Contributor

@viliam-durina viliam-durina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we can't do changes to binary format of JobConfig. The class must be backwards compatible because it's stored as a part of JobRecord and a cluster must be able to deserialize it after a rolling upgrade. It also can't use Versioned, because it's also sent in binary form from the client (see #20755). Therefore we can't do incompatible changes until the next major release.

@awelless
Copy link
Author

awelless commented Jun 3, 2022

@viliam-durina
Thanks.
This PR will be opened then. Before a merge I'll adapt it to any changes/new requirements, if needed

@neilstevenson
Copy link
Contributor

@awelless Is there any chance you could join our community Slack channel ? -- there's a link to do so here https://hazelcast.com/dev-community/.
We'd like to chat to you to find out if there's a way we can implement this feature somehow

@k-jamroz
Copy link
Collaborator

k-jamroz commented Oct 2, 2023

This can be achieved currently by using JobConfig.setArgument. It's not perfect but can be used to pass some extra data about the job.

@neilstevenson
Copy link
Contributor

I'll add a comment to #20510 discussing the motivation.

This fix seems pretty good, perhaps the wider problem is that Jet config does not support easy extension as new fields are required

@devOpsHazelcast
Copy link
Collaborator

PR closed by Hazelcast automation as no activity (>6 months). Please reopen with comments, if necessary. Thank you for using Hazelcast and your valuable contributions

@hz-devops-test
Copy link

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file
---------ERRORS-----------
--------------------------
[ERROR] Error executing Maven.
--------------------------

@nilnullneil
Copy link

Being able to describe jobs using a description field remains a useful need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: PR auto closed Source: Community PR or issue was opened by a community user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants