Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the Bump animal-sniffer-maven-plugin from 1.19 to 1.21 #20592

Merged
merged 1 commit into from Feb 3, 2022
Merged

Revert the Bump animal-sniffer-maven-plugin from 1.19 to 1.21 #20592

merged 1 commit into from Feb 3, 2022

Conversation

kwart
Copy link
Member

@kwart kwart commented Feb 3, 2022 •
edited

Reverts #20567 as it breaks Java 11+ builds

@kwart kwart added Type: Defect Team: Core Source: Internal PR or issue was opened by an employee dependencies Pull requests that update a dependency file labels Feb 3, 2022
@kwart kwart added this to the 5.1 milestone Feb 3, 2022
@kwart kwart requested a review from olukas February 3, 2022 07:59
@kwart
Copy link
Member Author

kwart commented Feb 3, 2022

So the behavior is not a bug, but it's a feature - see the mojohaus/animal-sniffer#83.

Version 1.19 only prints info messages, but 1.21 fails the build on covariant types.

22:38:59 [ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-master-sonar/hazelcast/src/main/java/com/hazelcast/jet/impl/connector/StreamSocketP.java:100: Undefined reference: java.nio.ByteBuffer java.nio.ByteBuffer.flip()
22:38:59 [ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-master-sonar/hazelcast/src/main/java/com/hazelcast/jet/impl/connector/StreamSocketP.java:101: Undefined reference: java.nio.CharBuffer java.nio.CharBuffer.clear()

We should consider if the new behavior is not the one we want by default. (CC @vbekiaris @frant-hartm )

@kwart kwart merged commit 875c4b6 into hazelcast:master Feb 3, 2022
@kwart kwart deleted the revert/5.1/20567-animal-sniffer branch February 3, 2022 08:40
@kwart
Copy link
Member Author

kwart commented Feb 3, 2022

Thanks for the review, Ondra.

@mmedenjak mmedenjak mentioned this pull request Feb 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olukas olukas olukas approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Source: Internal PR or issue was opened by an employee Team: Core Type: Defect
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwart @olukas