Fix mock connection management [HZ-836] #20371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ufukyilmaz
added
Team: Core
Type: Test-Failure
Source: Internal
added 2 commits
January 13, 2022 20:06
ufukyilmaz
commented
Jan 14, 2022
| } | ||
|
|
||
| if (lifecycleListener != null) { | ||
| lifecycleListener.onConnectionClose(this, cause, false); | ||
| } | ||
|
|
||
| if (localNodeEngine != null) { |
There was a problem hiding this comment.
This cleanup was already performed in onConnectionClose (MockServer#L354). But since the other side of the connection is not closed properly due to this error, this cleanup was not performed in the opposite side member.
ramizdundar
approved these changes
Jan 14, 2022
hazelcast/src/test/java/com/hazelcast/test/mocknetwork/MockServer.java
Outdated
Show resolved
Hide resolved
added 2 commits
January 14, 2022 13:03
|
run-lab-run |
vbekiaris
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
@ufukyilmaz kudos for cleaning up the mock server connections. I think the local/remote connection confusion is the reason why we got those test failures.
AyberkSorgun
changed the title
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues related to the hostname PR changes on the
mock connection manager. This caused the connections to the old members
not to be removed in the WAN tests which shutdowns and starts the cluster.
The main cause was that I changed (in the hostname PR) the used address
incorrectly in the place that we close the other side of connections (I was
mistakenly closing the connection on the same side again instead of the other
side.)
https://github.com/ufukyilmaz/hazelcast/blob/54013fe5f4fd2c48401fd3a229c6f47df59cd131/hazelcast/src/test/java/com/hazelcast/test/mocknetwork/MockServer.java#L364. I fixed that and then
cleaned up the code a bit.
Fixes: https://github.com/hazelcast/hazelcast-mono/issues/1617 and possibly
others
Octopus runs:
https://jenkins.hazelcast.com/job/Hazelcast-EE-octopus-pr-builder/510
https://jenkins.hazelcast.com/job/Hazelcast-EE-octopus-pr-builder/511 -> Similar test failures reported before in https://github.com/hazelcast/hazelcast-enterprise/issues/4270, https://github.com/hazelcast/hazelcast-enterprise/issues/4475)
http://jenkins.hazelcast.com/job/Hazelcast-EE-octopus-pr-builder/512/
Repeated runs of
MapWanSyncAPITest: http://jenkins.hazelcast.com/job/ufuk-test-runner/52/console (200 min run no failure)Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release NotesorNot Release Notes contentset