Improve single protocol handlers #19730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramizdundar
added
Type: Defect
Team: Core
Type: Test-Failure
Source: Internal
|
The job Click to expand the log file-------------------------- -------TEST FAILURE------- -------------------------- [INFO] Results: [INFO] [ERROR] Failures: [ERROR] SingleEncoderDecoderTest.testIncompatibleProtocolSentToClient[supportedProtocol:CLIENT, receivedProtocol:ASD] Expected test to throw an instance of com.hazelcast.internal.server.tcp.ProtocolException [ERROR] SingleEncoderDecoderTest.testIncompatibleProtocolSentToClient[supportedProtocol:CLIENT, receivedProtocol:HZC] Expected test to throw an instance of com.hazelcast.internal.server.tcp.ProtocolException [ERROR] SingleEncoderDecoderTest.testIncompatibleProtocolSentToClient[supportedProtocol:MEMBER, receivedProtocol:ASD] Expected test to throw an instance of com.hazelcast.internal.server.tcp.ProtocolException [ERROR] SingleEncoderDecoderTest.testIncompatibleProtocolSentToClient[supportedProtocol:MEMBER, receivedProtocol:CP2] Expected test to throw an instance of com.hazelcast.internal.server.tcp.ProtocolException [INFO] [ERROR] Tests run: 46505, Failures: 4, Errors: 0, Skipped: 1011 [INFO] |
AdvancedNetworkIntegrationTest#testCompleteMultisocketConfig covers this case because exception thrown in the SingleProtocolDecoder now.
|
It looks good to me in general. But, I will be waiting for |
kwart
approved these changes
Oct 7, 2021
ufukyilmaz
approved these changes
Oct 7, 2021
|
Thank you for the reviews. |
ramizdundar
added a commit
to ramizdundar/hazelcast
that referenced
this pull request
Oct 8, 2021
* Throw exception in the decoder instead of the encoder * Extend missing error handling to TextHandshakeDecoder * Delete SingleEncoderDecoderTest as it's no longer needed. (cherry picked from commit 4224341)
3 tasks
ramizdundar
added a commit
that referenced
this pull request
Oct 12, 2021
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18753 failed again because sometimes channel is closed before exception message is sent. I moved exceptions from decoder to encoder so this should be no longer a problem.
I also realized that TextHandshakeDecoder was missing some needed changes after SingleProtocolEncoder introduced. I also included them in this PR.
This PR should be backported to
5.0.z. I will backport after this PR is merged.Fixes #18753
Fixes https://github.com/hazelcast/hazelcast-mono/issues/1591
EE PR: https://github.com/hazelcast/hazelcast-enterprise/pull/4348
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release Noteslabel if changes should be mentioned in release notes orNot Release Notes contentif changes are not relevant for release notes