Convert staleJoinPreventionDuration to not static field #19623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to override this property in the EE side tests. We cannot achieve this when it's static.
ufukyilmaz
added
Team: Core
Type: Test-Failure
Source: Internal
|
The job Click to expand the log file-------------------------- ---------SUMMARY---------- -------------------------- [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:checkstyle (default) on project hazelcast: An error has occurred in Checkstyle report generation. Failed during checkstyle execution: There are 2 errors reported by Checkstyle 8.38 with /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder_3/checkstyle/checkstyle.xml ruleset. -> [Help 1] -------------------------- ---------ERRORS----------- -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder_3/hazelcast/src/main/java/com/hazelcast/internal/cluster/impl/ClusterJoinManager.java:134: Line is longer than 130 characters (found 133). [LineLength] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder_3/hazelcast/src/main/java/com/hazelcast/internal/cluster/impl/ClusterJoinManager.java:134:129: '30' is a magic number. [MagicNumber] -------------------------- |
vbekiaris
reviewed
Sep 23, 2021
hazelcast/src/main/java/com/hazelcast/internal/cluster/impl/ClusterJoinManager.java
Outdated
Show resolved
Hide resolved
…usterJoinManager.java Co-authored-by: Vassilis Bekiaris <vbekiaris@gmail.com>
|
The job Click to expand the log file-------------------------- ---------SUMMARY---------- -------------------------- [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:checkstyle (default) on project hazelcast: An error has occurred in Checkstyle report generation. Failed during checkstyle execution: There are 2 errors reported by Checkstyle 8.38 with /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/checkstyle/checkstyle.xml ruleset. -> [Help 1] -------------------------- ---------ERRORS----------- -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/main/java/com/hazelcast/internal/cluster/impl/ClusterJoinManager.java:134: Line is longer than 130 characters (found 133). [LineLength] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/main/java/com/hazelcast/internal/cluster/impl/ClusterJoinManager.java:134:129: '30' is a magic number. [MagicNumber] -------------------------- |
|
run-lab-run |
vbekiaris
approved these changes
Sep 24, 2021
ramizdundar
approved these changes
Sep 24, 2021
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to override this property in the EE side tests. We cannot
achieve this when it's static.
It's prerequisite for solving https://github.com/hazelcast/hazelcast-mono/issues/1592
EE PR: https://github.com/hazelcast/hazelcast-enterprise/pull/4318
Checklist:
Team:,Type:,Source:,Module:) and Milestone set