Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.2.2 BACKPORT] Enable instance tracking by default for NLC builds #19278

Merged
merged 2 commits into from Aug 6, 2021
Merged

[4.2.2 BACKPORT] Enable instance tracking by default for NLC builds #19278

merged 2 commits into from Aug 6, 2021

Commits on Aug 6, 2021

  1. Enable instance tracking by default for NLC builds 

    Instance tracking should be on by default, but only for NLC builds. The
field is set to true by the constructor but we need to introduce
additional changes to prevent instance tracking of being disabled even
though the user didn't add any configuration:
- we need to remove instances tracking config from both XML and YAML
default config files
- we need to prevent setting the enabled field unless there is content
found for the "enabled" field. Otherwise, even an empty instance
tracking config could be parsed by YAML parser, and it would disable
instance tracking
- also, NLC builds don't have a default file name and it should be
explicitly set. Non-NLC builds use the default file name.

Fixes: https://github.com/hazelcast/hazelcast-enterprise/issues/4166
    @mmedenjak
    mmedenjak committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    1d500e0 View commit details
    Browse the repository at this point in the history

  2. - added tests 

    - made tests use small instances
- addressed review comments
    @mmedenjak
    mmedenjak committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    70e8fd3 View commit details
    Browse the repository at this point in the history