Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled ClientStateListener to be used on FailoverClient #19115

Merged
merged 1 commit into from Jul 16, 2021
Merged

Enabled ClientStateListener to be used on FailoverClient #19115

merged 1 commit into from Jul 16, 2021

Commits on Jul 16, 2021

  1. Enabled ClientStateListener to be used on FailoverClient 

    Due to nature of how failover client works, we don't allow different
listeners to be registered at different client configs.

Since ClientStateListener registers itself to the ClientConfig,
this prevents it to be used via FailoverClient.

The reasoning behind constructor register itself is to force the
user to use this via config rather than registering it after client
starts.

So, sticking with the same decision we introduce another constructor
which accepts ClientFailoverConfig and registers same listener(itself)
to all the client configs.

Also on the ClientStateListener I have ignored CLIENT_CHANGED_CLUSTER.
This is rather a temporal event. We fire CLIENT_CONNECTED than
CLIENT_CHANGED_CLUSTER, in those cases we want the current state to
remain CLIENT_CONNECTED.

Fixes hazelcast#18351

EE PR: hazelcast/hazelcast-enterprise#4142

(cherry picked from commit e5fbd7b)
    sancar committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    38aa6c7 View commit details
    Browse the repository at this point in the history