[FORWARD PORT] Fail fast at startup for invalid WAN merge policy (#18875) #18928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifications: - Validate wan and split-brain merge policies at node-engine creation time to fail-fast at node start time. - Print a warning log at execution phase of MergeOperation to catch unreasonable merge-policy configs that cannot be catch at start-up time. Example to this is, you have WAN replication between 2 clusters, even though source cluster has per-entry-stats enabled, target cluster doesn't have it enabled. In this case, MergeOperation catches this anomaly and prints it as a warning.
|
The job Click to expand the log file--------------------------
-------TEST FAILURE-------
--------------------------
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] IndexStatsChangingNumberOfMembersTest.testIndexStatsQueryingChangingNumberOfMembers:139->awaitStable:431->HazelcastTestSupport.assertTrueEventually:1362->HazelcastTestSupport.assertTrueEventually:1260->lambda$awaitStable$0:443 MemberPartitions={size=90, partitions=[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 91]}, IndexImpl{partitionTracker=GlobalIndexPartitionTracker{partitionCount=271, state=State{stamp=516, indexedPartitions={size=84, partitions=[0, 1, 2, 6, 8, 9, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 91]}, pending=0}}} AbstractIndex{config=IndexConfig{name=this, type=HASH, attributes=[this]}}. Actual: -1
[ERROR] Errors:
[ERROR] TransactionalMultiMapSplitBrainProtectionWriteTest.setUp:78->AbstractSplitBrainProtectionTest.initTestEnvironment:105->AbstractSplitBrainProtectionTest.initCluster:247 ? SplitBrainProtection
[INFO]
[ERROR] Tests run: 38545, Failures: 1, Errors: 1, Skipped: 1004
[INFO]
|
blazember
approved these changes
Jun 17, 2021
mmedenjak
added
Module: IMap
Module: WAN
Source: Internal
mmedenjak
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forward port of #18875 (cherry-picked)