Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty print cluster connect timeout in logs #18648

Merged
merged 1 commit into from May 6, 2021
Merged

Pretty print cluster connect timeout in logs #18648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 13 additions & 4 deletions hazelcast/src/main/java/com/hazelcast/client/impl/connection/tcp/WaitStrategy.java
View file
Open in desktop
Expand Up @@ -32,6 +32,7 @@ public class WaitStrategy {
private int attempt;
private int currentBackoffMillis;
private final long clusterConnectTimeoutMillis;
private final String clusterConnectTimeoutText;
private long clusterConnectAttemptBegin;

WaitStrategy(int initialBackoffMillis, int maxBackoffMillis,
Expand All @@ -40,6 +41,13 @@ public class WaitStrategy {
this.maxBackoffMillis = maxBackoffMillis;
this.multiplier = multiplier;
this.clusterConnectTimeoutMillis = clusterConnectTimeoutMillis;
if (clusterConnectTimeoutMillis == Long.MAX_VALUE) {
// For a better logging output for the default values, we will
// replace "Long.MAX_VALUE ms" with this in our output.
clusterConnectTimeoutText = "INFINITE";
} else {
clusterConnectTimeoutText = clusterConnectTimeoutMillis + " ms";
}
this.jitter = jitter;
this.logger = logger;
}
Expand All @@ -54,9 +62,10 @@ public boolean sleep() {
attempt++;
long currentTimeMillis = Clock.currentTimeMillis();
long timePassed = currentTimeMillis - clusterConnectAttemptBegin;

if (timePassed > clusterConnectTimeoutMillis) {
logger.warning(String.format("Unable to get live cluster connection, cluster connect timeout (%d ms) is "
+ "reached. Attempt %d.", clusterConnectTimeoutMillis, attempt));
logger.warning(String.format("Unable to get live cluster connection, cluster connect timeout (%s) is "
+ "reached. Attempt %d.", clusterConnectTimeoutText, attempt));
return false;
}

Expand All @@ -68,8 +77,8 @@ public boolean sleep() {
actualSleepTime = Math.min(actualSleepTime, clusterConnectTimeoutMillis - timePassed);

logger.warning(String.format("Unable to get live cluster connection, retry in %d ms, attempt: %d"
+ ", cluster connect timeout: %d ms"
+ ", max backoff: %d ms", actualSleepTime, attempt, clusterConnectTimeoutMillis, maxBackoffMillis));
+ ", cluster connect timeout: %s"
+ ", max backoff: %d ms", actualSleepTime, attempt, clusterConnectTimeoutText, maxBackoffMillis));

try {
Thread.sleep(actualSleepTime);
Expand Down