Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LRU comparison by adding creation time #18632

Merged
merged 2 commits into from Jun 16, 2021
Merged

Fix LRU comparison by adding creation time #18632

merged 2 commits into from Jun 16, 2021

Conversation

ahmetmircik
Copy link
Member

backport of #18624

@ahmetmircik ahmetmircik added this to the 4.1.4 milestone May 4, 2021
@ahmetmircik ahmetmircik changed the title Fix lru eviction algorithm Fix lru comparison algorithm May 4, 2021
@ahmetmircik ahmetmircik changed the title Fix lru comparison algorithm Fix LRU comparison algorithm May 4, 2021
@mmedenjak mmedenjak added Source: Internal PR or issue was opened by an employee Team: Core Backport labels May 17, 2021
@mmedenjak mmedenjak changed the title Fix LRU comparison algorithm [BACKPORT] Fix LRU comparison algorithm Jun 16, 2021
@mmedenjak mmedenjak mentioned this pull request Jun 16, 2021
Merged
mmedenjak
mmedenjak reviewed Jun 16, 2021
View reviewed changes
Copy link
Contributor

@mmedenjak mmedenjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but how come we don't set the access time in AbstractRecordStore#createRecord like in the other PRs?

@ahmetmircik
Copy link
Member Author

@mmedenjak i didn't change the behavior for 4.1 in patch. In this version, you can distinguish last-access-time from creation-time since last-access-time is set when record is accessed not created.

@ahmetmircik ahmetmircik changed the title [BACKPORT] Fix LRU comparison algorithm Fix LRU comparison by adding creation time Jun 16, 2021
@ahmetmircik ahmetmircik merged commit fcc1a74 into hazelcast:4.1.z Jun 16, 2021
@ahmetmircik ahmetmircik deleted the 4.1.x/fix/lruImpl branch June 16, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmedenjak mmedenjak mmedenjak approved these changes

@vbekiaris vbekiaris Awaiting requested review from vbekiaris

Assignees
No one assigned
Labels
Backport Module: IMap Source: Internal PR or issue was opened by an employee Team: Core Type: Defect
Projects
None yet
Milestone
4.1.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahmetmircik @mmedenjak