Fix HD leak for EP that run on Map keys #17271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkountis
force-pushed
the
fix/hd-leak-ep_on_keys
branch
from
d85d1a9
to
571fd08
Compare
|
Can you add an explanation of the cause of the leak? |
sancar
approved these changes
Jul 28, 2020
pveentjer
approved these changes
Jul 28, 2020
|
The design sounds flaky. But good to see that the issue is fixed. |
tkountis
pushed a commit
to tkountis/hazelcast
that referenced
this pull request
Jul 28, 2020
(cherry picked from commit 889126e) (cherry picked from commit dc6b9ed3ccabfb504ff4f3de742d1a31892d59e2)
tkountis
pushed a commit
to tkountis/hazelcast
that referenced
this pull request
Jul 28, 2020
(cherry picked from commit 889126e)
tkountis
pushed a commit
to tkountis/hazelcast
that referenced
this pull request
Jul 28, 2020
(cherry picked from commit 889126e)
tkountis
pushed a commit
that referenced
this pull request
Jul 29, 2020
tkountis
pushed a commit
that referenced
this pull request
Jul 29, 2020
tkountis
pushed a commit
that referenced
this pull request
Jul 29, 2020
|
@tkountis do we need to forward-port this to 4.x? EDIT: I found it :) |
This was referenced Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client action is constructing a
MultipleEntryOperationFactoryat all times, instead of using theOperationProviderwhich constructs a map-relevant instance of that factory, in this case anHDMultipleEntryOperationFactory.A post-action of the EP operation, does some allocations (irrelevant to the context), which are correctly placed in the deferred-disposal queue (which is executed on all HD operations afterRun). However, since the EntryOperation was not an HD operation the afterRun disposal never took place.
The problem is limited to this client action (
executeOnKeys), and its been like that for many years.Test: https://github.com/hazelcast/hazelcast-enterprise/pull/3692
Fixes: https://github.com/hazelcast/hazelcast-enterprise/issues/3689
3.11.z: #17275
4.0.z: #17274
4.1: #17276