TenantControl - creating cache records must use tenant #17121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when factories get invoked, appropriate tenant environment is created
ghost
added
the
|
|
vbekiaris
reviewed
Jun 23, 2020
hazelcast/src/main/java/com/hazelcast/cache/impl/AbstractCacheRecordStore.java
Outdated
Show resolved
Hide resolved
vbekiaris
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
looks good, just one comment about exception throwing. Also, run mvn -Pcheckstyle clean install locally to ensure you fixed the checkstyle errors. Here is the output from PR builder:
04:46:51 [INFO] --- maven-checkstyle-plugin:2.15:checkstyle (default) @ hazelcast ---
04:47:24 [INFO] Starting audit...
04:47:24 /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/main/java/com/hazelcast/cache/impl/AbstractCacheRecordStore.java:153:5: Method length is 69 lines (max allowed is 60).
04:47:24 Audit done.
- moved some of constructor's functionality into a private method to comply with checkstyle rules
|
I have fixed the failed test |
pveentjer
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.12.X
Wrapped factory instantiation in try/finally block with tenant control enabled.
This is so factories have their tenant environment set
Please view diff w/o whitespace changes to make it a very easy diff :)
4.0 version of this PR #17122