Add nearcaching hook to map-transaction-log-record #16581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetmircik
force-pushed
the
fix/3.12.7/txNC
branch
3 times, most recently
from
e837b63
to
e450c75
Compare
|
run-lab-run |
petrpleshachkov
approved these changes
Mar 12, 2020
mmedenjak
reviewed
Mar 12, 2020
| @@ -175,18 +175,41 @@ public void commit() throws TransactionException, IllegalStateException { | |||
| } | |||
| } | |||
|
|
|||
| public void commitAsync(ExecutionCallback callback) { | |||
| public void commitAsync(final ExecutionCallback callback) { | |||
There was a problem hiding this comment.
Shouldn't we add these too?
https://github.com/hazelcast/hazelcast/pull/16579/files#diff-0c104d8009708b16b9092edfd2438fa1R173-R176
| } | ||
| }; | ||
|
|
||
| void beforeRemoteCall(K key, Data keyData, V value, Data valueData); |
There was a problem hiding this comment.
How come you don't use @Nullable here?
There was a problem hiding this comment.
It wasn't common in 3.12 (java 6) using those, no real reason.
| public MapTransactionLogRecord() { | ||
| } | ||
|
|
||
| public MapTransactionLogRecord(String name, Data key, int partitionId, Operation op, long version, String ownerUuid) { | ||
| public MapTransactionLogRecord(String name, Data key, int partitionId, |
There was a problem hiding this comment.
Can the parameter be@Nullable?
|
run-lab-run |
ahmetmircik
force-pushed
the
fix/3.12.7/txNC
branch
from
e450c75
to
d31358d
Compare
mmedenjak
approved these changes
Mar 17, 2020
ahmetmircik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16577
Backport of: #16579