Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont keep the endpoint reference to clean client resources #13755

Commits on Sep 13, 2018

  1. Dont keep the endpoint reference to clean client resources

    We are scheduling a task to clean client resources after some
    time(60 seconds). Eventough endpoint is removed, we were keeping
    a reference to it via this task. This was causing unncessary leak
    for 60 seconds since the endpoint keeps reference to heavy objects
    like `connection`.
    
    With this pr, we are passing only necessary fields objects of
    client endpoint to task to avoid keeping reference to the client
    endpoint itself.
    
    (cherry picked from commit e3632c6)
    sancar committed Sep 13, 2018
    Copy the full SHA
    d5027d3 View commit details
    Browse the repository at this point in the history