Do not fire MERGE events when merging MultiMap entries #13703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes hazelcast#13559 Multimap does not have MERGE listener anyway hence it's pointless to fire MERGE events. I also added additional parameters to the MultiMap split-brain test to test every merge policy for both BINARY and OBJECT formats.
jerrinot
commented
Sep 7, 2018
| @@ -133,6 +142,11 @@ protected void onAfterSplitBrainCreated(HazelcastInstance[] firstBrain, Hazelcas | |||
| multiMapA2 = secondBrain[0].getMultiMap(multiMapNameA); | |||
| multiMapB2 = secondBrain[0].getMultiMap(multiMapNameB); | |||
|
|
|||
| EntryListener<Object, Object> listener = new EmptyEntryListener<Object, Object>(); | |||
There was a problem hiding this comment.
this is the important bit for the test
vbekiaris
approved these changes
Sep 10, 2018
mmedenjak
approved these changes
Sep 10, 2018
This was referenced Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13559
Multimap does not have MERGE listener anyway hence it's pointless
to fire MERGE events.
I also added additional parameters to the MultiMap split-brain test
to test every merge policy for both BINARY and OBJECT formats.
Backport will follow.