Forward map value extractors to HD indexes #13692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes two issues: 1. The consistency issue: queryable entries returned by HD indexes were unaware of the map value extractors, so it was impossible to extract values provided by the extractors from the returned entries. 2. The performance issue: Extractors.empty is a pretty expensive call and it was performed for every returned entry. According to a slightly modified version of HDIndexPerfTest the throughput is about 2 times higher now. Fixes: https://github.com/hazelcast/hazelcast-enterprise/issues/2109
|
Great work Sergey! I'll check it as soon as I have time. You are saving the day here! |
|
This PRD needs to be backported to 3.10.6. |
|
@pveentjer 3.10.6 or 3.10.5? |
vbekiaris
approved these changes
Sep 13, 2018
|
Two approvals, merging. Thanks for the reviews @jerrinot @vbekiaris ! |
|
@taburet can you backport to 3.10.x? Thanks! |
|
Backport is added #13775 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EE part: https://github.com/hazelcast/hazelcast-enterprise/pull/2227
This change fixes two issues:
The consistency issue: queryable entries returned by HD indexes were
unaware of the map value extractors, so it was impossible to extract
values provided by the extractors from the returned entries.
The performance issue: Extractors.empty is a pretty expensive call
and it was performed for every returned entry. According to a slightly
modified version of HDIndexPerfTest the throughput is about 2 times
higher now.
Fixes: https://github.com/hazelcast/hazelcast-enterprise/issues/2109