Server should not close clients when client only listens #13577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client was not sending Ping to server when last read time is up-to-date. When server constantly pushes events to client, client does not send any ping to server. And consequently, server closes client because it does not send any ping. Client logic has changed so that it send pings if there is no outgoing packages recently, rarther than looking at incoming packages. fixes hazelcast#13576
sancar
force-pushed
the
fix/serverClosesListeningClient/master
branch
from
9bb70fa
to
c8c193f
Compare
ihsandemir
reviewed
Aug 17, 2018
| @Category(SlowTest.class) | ||
| public void testServerShouldNotCloseClientWhenClientOnlyListening() { | ||
| Config config = new Config(); | ||
| int clientHeartbeatSeconds = 8; |
There was a problem hiding this comment.
why 8 secs and not a shorter duration? This seems to cause it to be a slow test.
There was a problem hiding this comment.
When it is shorter it could fail when environment is slow. That is why I wanted to keep it longer.
ihsandemir
approved these changes
Aug 27, 2018
This was referenced Aug 28, 2018
asimarslan
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client was not sending Ping to server when last read time is
up-to-date. When server constantly pushes events to client,
client does not send any ping to server. And consequently,
server closes client because it does not send any ping.
Client logic has changed so that it send pings if there is no
outgoing packages recently, rarther than looking at incoming
packages.
fixes #13576