Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lock timeout behaviour when key owner is gone #13554

Conversation

sancar
Copy link
Contributor

@sancar sancar commented Aug 9, 2018

When a client waiting on lock to get it, if the member that it
is waiting on shuts down/terminated , client retries it on new
owner of the lock.

If a client waits for longer than client.invocation.timeout.seconds,
when exception came from server, it is wrapped inside
OperationTimeoutException and thrown to user.
This pr changes this behaviour so that waiting lock operations
(map.lock/trylock lock.lock/trylock condition.await) operations will
not throw OperationTimeoutException but retry the operation.

fixes #13551

(cherry picked from commit 79fac3c)

When a client waiting on lock to get it, if the member that it
is waiting on shuts down/terminated , client retries it on new
owner of the lock.

If a client waits for longer than client.invocation.timeout.seconds,
when exception came from server, it is wrapped inside
OperationTimeoutException and thrown to user.
This pr changes this behaviour so that waiting lock operations
(map.lock/trylock lock.lock/trylock condition.await) operations will
not throw OperationTimeoutException but retry the operation.

fixes hazelcast#13551

(cherry picked from commit 79fac3c)
@sancar sancar added this to the 3.10.5 milestone Aug 9, 2018
@sancar sancar self-assigned this Aug 9, 2018
@sancar sancar added the Backport label Aug 9, 2018
@sancar sancar merged commit 65d4f9b into hazelcast:maintenance-3.x Aug 28, 2018
@sancar sancar deleted the fix/lockTimeoutsWhenKeyonerGone/maint3.x branch August 28, 2018 08:13
@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants