New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lock timeout behaviour when key owner is gone #13552
Merged
sancar
merged 1 commit into
hazelcast:master
from
sancar:fix/lockTimeoutsWhenKeyonerGone/master
Aug 28, 2018
Merged
Fix lock timeout behaviour when key owner is gone #13552
sancar
merged 1 commit into
hazelcast:master
from
sancar:fix/lockTimeoutsWhenKeyonerGone/master
Aug 28, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a client waiting on lock to get it, if the member that it is waiting on shuts down/terminated , client retries it on new owner of the lock. If a client waits for longer than client.invocation.timeout.seconds, when exception came from server, it is wrapped inside OperationTimeoutException and thrown to user. This pr changes this behaviour so that waiting lock operations (map.lock/trylock lock.lock/trylock condition.await) operations will not throw OperationTimeoutException but retry the operation. fixes hazelcast#13551
ihsandemir
approved these changes
Aug 17, 2018
asimarslan
approved these changes
Aug 28, 2018
This was referenced Aug 28, 2018
sancar
pushed a commit
to sancar/hazelcast
that referenced
this pull request
Sep 5, 2018
follow up to hazelcast#13552 One of the lock methods was missed in that pr. Along with the fix ,this pr also includes a test for all related lock methods.
sancar
pushed a commit
to sancar/hazelcast
that referenced
this pull request
Sep 5, 2018
follow up to hazelcast#13552 One of the lock methods was missed in that pr. Along with the fix ,this pr also includes a test for all related lock methods. (cherry picked from commit 05eb772)
This was referenced Sep 5, 2018
sancar
pushed a commit
to sancar/hazelcast
that referenced
this pull request
Sep 6, 2018
follow up to hazelcast#13552 One of the lock methods was missed in that pr. Along with the fix ,this pr also includes a test for all related lock methods. (cherry picked from commit 05eb772)
sancar
pushed a commit
to sancar/hazelcast
that referenced
this pull request
Sep 6, 2018
follow up to hazelcast#13552 One of the lock methods was missed in that pr. Along with the fix ,this pr also includes a test for all related lock methods. (cherry picked from commit 05eb772)
sancar
pushed a commit
to sancar/hazelcast
that referenced
this pull request
Sep 6, 2018
follow up to hazelcast#13552 One of the lock methods was missed in that pr. Along with the fix ,this pr also includes a test for all related lock methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client waiting on lock to get it, if the member that it
is waiting on shuts down/terminated , client retries it on new
owner of the lock.
If a client waits for longer than client.invocation.timeout.seconds,
when exception came from server, it is wrapped inside
OperationTimeoutException and thrown to user.
This pr changes this behaviour so that waiting lock operations
(map.lock/trylock lock.lock/trylock condition.await) operations will
not throw OperationTimeoutException but retry the operation.
fixes #13551