Throw ClientNotActiveException instead of generic HazelcastException #13524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sancar
force-pushed
the
fix/exceptionType/master
branch
from
e244fe7
to
75a9483
Compare
|
backport PR: #13525 |
|
This is a breaking change since HazelcastClientNotActiveException extends IllegalStateException; not HazelcastException. |
|
For anyone comes later. The discussion about whether this is a breaking change or not is done in backport branch extensively. |
ihsandemir
approved these changes
Sep 19, 2018
asimarslan
approved these changes
Sep 24, 2018
alive check in ClientConnectionManager is moved to a more centralized method and type of the exception is fixed.
sancar
force-pushed
the
fix/exceptionType/master
branch
from
75a9483
to
ae4a159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alive check in ClientConnectionManager is moved to a more centralized
method and type of the exception is fixed.