[BACKPORT] Fix constructor cache in ClassLoaderUtil #13511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cangencer
reviewed
Jul 31, 2018
| @@ -102,13 +102,13 @@ private ClassLoaderUtil() { | |||
| return newInstance(klass, classLoader, className); | |||
| } | |||
|
|
|||
| public static <T> T newInstance(Class<T> klass, ClassLoader classLoader, String className) throws Exception { | |||
| public static <T> T newInstance(Class<T> klass, ClassLoader unused, String className) throws Exception { | |||
There was a problem hiding this comment.
would it be ok to remove this parameter altogether?
jerrinot
suggested changes
Jul 31, 2018
There was a problem hiding this comment.
This effectively disable caching in the case of delegating classloaders.
The code should populate the constructor cache with the classloader which was used to load the class. because that's what the cache lookup code is using.
however you are now populating the cache with a classloader which was used to define the class.
viliam-durina
changed the title
cangencer
added
the
Source: Jet
- The constructor will be cached with the class loader (CL) that returned the class. Fixes hazelcast#13509 - The same CL could be queried multiple times (performance problem) - the thread's context CL wasn't used at all for `com.hazelcast` package. This problem partly remains, see comment in code. - add documentation - make the oddly-defined 3-arg `newInstance` method private
cangencer
force-pushed
the
constructor-cache-fix-backport
branch
from
ee1cdfb
to
7d18f7d
Compare
cangencer
changed the title
|
Closing in favour of #13679 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13509
Backport of #13512