Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactional put/set operation should replicate result of interceptPut #13499

Merged
merged 1 commit into from Sep 10, 2018
Merged

Transactional put/set operation should replicate result of interceptPut #13499

merged 1 commit into from Sep 10, 2018

Conversation

mdogan
Copy link
Contributor

@mdogan mdogan commented Jul 27, 2018

TxnSetOperation was not taking changes made by MapInterceptor into account
while sending backups.

Fixes #12705

@mdogan mdogan added this to the 3.11 milestone Jul 27, 2018
@mdogan mdogan mentioned this pull request Jul 27, 2018
Merged
blazember
blazember approved these changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@blazember blazember left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One thing though: it seems that LegacyMergeOperation is also affected by the same issue if the configured MapStore is a PostProcessingMapStore. Shouldn't that one also follow the parent's logic for creating backup op?

@mdogan
Transactional put/set operation should replicate result of interceptPut
ec94153 
`TxnSetOperation` was not taking changes made by `MapInterceptor` into account
while sending backups.
@mdogan
Copy link
Contributor Author

mdogan commented Sep 10, 2018 •
edited

@blazember: Can you please take a look again? I included a fix for LegacyMergeOperation too.

@mdogan mdogan merged commit 86a579d into hazelcast:master Sep 10, 2018
@mdogan mdogan deleted the map-interceptor-tx branch September 10, 2018 11:06
@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbekiaris vbekiaris vbekiaris approved these changes

@blazember blazember blazember approved these changes

Assignees
No one assigned
Labels
Module: IMap Module: Transactions Source: Internal PR or issue was opened by an employee Team: Core Type: Defect
Projects
None yet
Milestone
3.11
Development

Successfully merging this pull request may close these issues.

Committing/rolling-back already committed transaction after one of node is killed
4 participants
@mdogan @vbekiaris @blazember @mmedenjak