Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

com.hazelcast.client.config.ClientTpcConfigTest mixes JUnit 4 & 5 assertions #26193

Open
JackPGreen opened this issue Dec 20, 2023 · 1 comment · May be fixed by #26265
Open

com.hazelcast.client.config.ClientTpcConfigTest mixes JUnit 4 & 5 assertions #26193

JackPGreen opened this issue Dec 20, 2023 · 1 comment · May be fixed by #26265
Labels
good first issue Good for newcomers Source: Internal PR or issue was opened by an employee Team: Core

Comments

@JackPGreen
Copy link
Contributor

JackPGreen commented Dec 20, 2023 •
edited

com.hazelcast.client.config.ClientTpcConfigTest uses both org.junit.Assert.assertFalse (JUnit4) & org.junit.jupiter.api.Assertions.assertTrue (JUnit5) .

  • This should only use one version (probably JUnit4 based on the frequency of imports)
  • This should have been caught by com.hazelcast.NoMixedJUnitAnnotationsInOurTestSourcesTest.noJUnitMixing() and failed the tests

A similar scenario occurs in com.hazelcast.osgi.HazelcastOSGiIT - org.junit.experimental.categories.Category (JUnit4) & org.junit.jupiter.api.AfterEach (JUnit5)
@JackPGreen JackPGreen added Team: Core Source: Internal PR or issue was opened by an employee good first issue Good for newcomers labels Dec 21, 2023
mohyazdanpanah added a commit to mohyazdanpanah/hazelcast that referenced this issue Dec 23, 2023
@mohyazdanpanah
Integrate junit version in ClientTpcConfigTest and HazelcastOSGiIT te…
164d0b4 
…st classes hazelcast#26193
@mohyazdanpanah mohyazdanpanah mentioned this issue Dec 23, 2023
Open
6 tasks
@dr-divago
Copy link

Hi @JackPGreen is this issue still open?

@dr-divago dr-divago linked a pull request Feb 25, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Source: Internal PR or issue was opened by an employee Team: Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed JUnit5 dependency for ClientTpcConfigTest dr-divago/hazelcast
2 participants
@dr-divago @JackPGreen