Dont keep the endpoint reference to clean client resources #13755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are scheduling a task to clean client resources after some time(60 seconds). Eventough endpoint is removed, we were keeping a reference to it via this task. This was causing unncessary leak for 60 seconds since the endpoint keeps reference to heavy objects like `connection`. With this pr, we are passing only necessary fields objects of client endpoint to task to avoid keeping reference to the client endpoint itself. (cherry picked from commit e3632c6)
asimarslan
approved these changes
Sep 13, 2018
sancar
deleted the
fix/letEndpointReferenceGoWhenClientDisconnected/maint3.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are scheduling a task to clean client resources after some
time(60 seconds). Eventough endpoint is removed, we were keeping
a reference to it via this task. This was causing unncessary leak
for 60 seconds since the endpoint keeps reference to heavy objects
like
connection.With this pr, we are passing only necessary fields objects of
client endpoint to task to avoid keeping reference to the client
endpoint itself.
(cherry picked from commit e3632c6)