Skip to content

Commit

Permalink
There is a very severe performance issue with JDK 8 in combination with
Browse files Browse the repository at this point in the history
the paging predicate. This is caused by SubList.sort. This issue is resolved
with JDK9 but we need to fix the issue for a large number of people using
JDK 8

The problem is fixed by switching from LinkedList to ArrayList in the
QueryResult. Benchmarks are included in the ticket

fix #17207
  • Loading branch information
pveentjer committed Jul 14, 2020
1 parent 2767be4 commit 8d0be00
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
import java.util.ArrayList;
import java.util.Collection;
import java.util.Iterator;
import java.util.LinkedList;
import java.util.List;
import java.util.ListIterator;
import java.util.Map;
Expand Down Expand Up @@ -60,7 +59,7 @@
*/
public class QueryResult implements Result<QueryResult>, Iterable<QueryResultRow> {

private List rows = new LinkedList();
private List rows = new ArrayList();

private Collection<Integer> partitionIds;
private IterationType iterationType;
Expand Down

0 comments on commit 8d0be00

Please sign in to comment.