Merge pull request #13743 from jerrinot/fixes/reduce-chattiness/master

Reduce chattiness when starting Hazelcast

hazelcast/src/main/java/com/hazelcast/instance/DefaultNodeExtension.java

@@ -156,7 +156,7 @@ public void printNodeInfo() {
         systemLogger.info("Hazelcast " + buildInfo.getVersion()
                 + " (" + build + ") starting at " + node.getThisAddress());
         systemLogger.info("Copyright (c) 2008-2018, Hazelcast, Inc. All Rights Reserved.");
-        systemLogger.info("Configured Hazelcast Serialization version: " + buildInfo.getSerializationVersion());
+        systemLogger.fine("Configured Hazelcast Serialization version: " + buildInfo.getSerializationVersion());
     }
 
     @Override
@@ -345,7 +345,9 @@ public void onMemberListChange() {
 
     @Override
     public void onClusterVersionChange(Version newVersion) {
-        systemLogger.info("Cluster version set to " + newVersion);
+        if (!node.getVersion().asVersion().isEqualTo(newVersion)) {
+            systemLogger.info("Cluster version set to " + newVersion);
+        }
         ServiceManager serviceManager = node.getNodeEngine().getServiceManager();
         List<ClusterVersionListener> listeners = serviceManager.getServices(ClusterVersionListener.class);
         for (ClusterVersionListener listener : listeners) {

hazelcast/src/main/java/com/hazelcast/internal/cluster/impl/ClusterStateManager.java

@@ -323,7 +323,9 @@ public void commitClusterState(ClusterStateChange stateChange, Address initiator
                 }
             } else if (stateChange.isOfType(Version.class)) {
                 // version is validated on cluster-state-lock, thus we can commit without checking compatibility
-                doSetClusterVersion((Version) stateChange.getNewState());
+                Version newVersion = (Version) stateChange.getNewState();
+                logger.info("Cluster version set to " + newVersion);
+                doSetClusterVersion(newVersion);
                 node.getClusterService().getMembershipManager().scheduleMemberListVersionIncrement();
             } else {
                 throw new IllegalArgumentException("Illegal ClusterStateChange of type " + stateChange.getType() + ".");

hazelcast/src/main/java/com/hazelcast/nio/tcp/TcpIpAcceptor.java

@@ -270,7 +270,9 @@ private void acceptSocket() {
 
             if (channel != null) {
                 final Channel theChannel = channel;
-                logger.info("Accepting socket connection from " + theChannel.socket().getRemoteSocketAddress());
+                if (logger.isFineEnabled()) {
+                    logger.fine("Accepting socket connection from " + theChannel.socket().getRemoteSocketAddress());
+                }
                 if (ioService.isSocketInterceptorEnabled()) {
                     ioService.executeAsync(new Runnable() {
                         @Override

hazelcast/src/main/java/com/hazelcast/nio/tcp/TcpIpConnection.java

@@ -31,6 +31,10 @@
 import java.net.InetSocketAddress;
 import java.nio.channels.CancelledKeyException;
 import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.logging.Level;
+
+import static com.hazelcast.nio.ConnectionType.MEMBER;
+import static com.hazelcast.nio.ConnectionType.NONE;
 
 /**
  * The Tcp/Ip implementation of the {@link com.hazelcast.nio.Connection}.
@@ -59,7 +63,7 @@ public class TcpIpConnection implements Connection {
 
     private TcpIpConnectionErrorHandler errorHandler;
 
-    private volatile ConnectionType type = ConnectionType.NONE;
+    private volatile ConnectionType type = NONE;
 
     private volatile Throwable closeCause;
 
@@ -87,8 +91,14 @@ public ConnectionType getType() {
 
     @Override
     public void setType(ConnectionType type) {
-        if (this.type == ConnectionType.NONE) {
-            this.type = type;
+        if (this.type != NONE) {
+            return;
+        }
+
+        this.type = type;
+        if (type == MEMBER) {
+            logger.info("Initialized new cluster connection between "
+                        + channel.localSocketAddress() + " and " + channel.remoteSocketAddress());
         }
     }
 
@@ -152,7 +162,7 @@ public int getConnectionId() {
     @Override
     public boolean isClient() {
         ConnectionType t = type;
-        return t != null && t != ConnectionType.NONE && t.isClient();
+        return t != null && t != NONE && t.isClient();
     }
 
     @Override
@@ -210,6 +220,11 @@ public void close(String reason, Throwable cause) {
     }
 
     private void logClose() {
+        Level logLevel = resolveLogLevelOnClose();
+        if (!logger.isLoggable(logLevel)) {
+            return;
+        }
+
         String message = toString() + " closed. Reason: ";
         if (closeReason != null) {
             message += closeReason;
@@ -219,18 +234,27 @@ private void logClose() {
             message += "Socket explicitly closed";
         }
 
-        if (ioService.isActive()) {
-            if (closeCause == null || closeCause instanceof EOFException || closeCause instanceof CancelledKeyException) {
-                logger.info(message);
-            } else {
-                logger.warning(message, closeCause);
-            }
+        if (closeCause == null) {
+            logger.log(logLevel, message);
         } else {
-            if (closeCause == null) {
-                logger.finest(message);
+            logger.log(logLevel, message, closeCause);
+        }
+    }
+
+    private Level resolveLogLevelOnClose() {
+        if (!ioService.isActive()) {
+            return Level.FINEST;
+        }
+
+        if (closeCause == null || closeCause instanceof EOFException || closeCause instanceof CancelledKeyException) {
+            if (type == ConnectionType.REST_CLIENT || type == ConnectionType.MEMCACHE_CLIENT) {
+                // text-based clients are expected to come and go frequently.
+                return Level.FINE;
             } else {
-                logger.finest(message, closeCause);
+                return Level.INFO;
             }
+        } else {
+            return Level.WARNING;
         }
     }
 

hazelcast/src/main/java/com/hazelcast/nio/tcp/TcpIpConnectionManager.java

@@ -369,8 +369,10 @@ synchronized TcpIpConnection newConnection(Channel channel, Address endpoint) {
             connection.setEndPoint(endpoint);
             activeConnections.add(connection);
 
-            logger.info("Established socket connection between "
-                    + channel.localSocketAddress() + " and " + channel.remoteSocketAddress());
+            if (logger.isFineEnabled()) {
+                logger.fine("Established socket connection between "
+                        + channel.localSocketAddress() + " and " + channel.remoteSocketAddress());
+            }
             openedCount.inc();
 
             channel.start();

hazelcast/src/main/java/com/hazelcast/spi/impl/operationservice/impl/InboundResponseHandlerSupplier.java

@@ -109,7 +109,9 @@ protected MutableInteger initialValue() {
             throw new IllegalArgumentException(RESPONSE_THREAD_COUNT.getName() + " can't be smaller than 0");
         }
 
-        logger.info("Running with " + responseThreadCount + " response threads");
+        if (logger.isFineEnabled()) {
+            logger.fine("Running with " + responseThreadCount + " response threads");
+        }
 
         this.responseThreads = new ResponseThread[responseThreadCount];
         if (responseThreadCount == 0) {