[HZAI-68] Initial vector search implementation #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuce
changed the title
yuce
changed the title
srknzl
reviewed
May 6, 2024
Comment on lines
+84
to
+86
| jvector = download_if_necessary(RELEASE_REPO, "io.github.jbellis", "jvector", "2.0.5") | ||
| artifacts.append(jvector) | ||
| math3 = download_if_necessary(RELEASE_REPO, "org.apache.commons", "commons-math3", "3.6.1") |
There was a problem hiding this comment.
I'd say let's put these versions at the top of the file, next to SERVER_VERSION &
RC_VERSION.
Why do we need these jars though? Should not "hazelcast-enterprise-vector" include them(any dependency needed for vectors) already? If you are going to shade those dependencies into hazelcast-enterprise-vector soon, I'd add a todo comment here about removing these dependencies from here because it seems this pr will be open for a while until 5.4 is released
There was a problem hiding this comment.
Currently hazelcast-enterprise-vector jar doesn't include those dependencies.
But eventually it will, so we can just delete those lines when that happens.
srknzl
previously approved these changes
May 8, 2024
# Conflicts: # .github/workflows/nightly_runner.yml
srknzl
approved these changes
Jun 3, 2024
yuce
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
VectorCollectionproxy. TDD is at: https://hazelcast.atlassian.net/wiki/spaces/EN/pages/4853530644/Python+API+and+Client+Protocol+for+VectorCollectiondataclass)