Fix map status when MapConfig creation failed [CN-1226] #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeriyBg
requested review from
hasancelik and
semihbkgr
and removed request for
a team
semihbkgr
approved these changes
May 20, 2024
SeriyBg
added
fix
hasancelik
reviewed
May 21, 2024
| @@ -137,8 +137,8 @@ func (r *MapReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.R | |||
|
|
|||
| ms, err := r.ReconcileMapConfig(ctx, m, h, cl, createdBefore) | |||
| if err != nil { | |||
| return updateMapStatus(ctx, r.Client, m, recoptions.RetryAfter(retryAfterForMap), | |||
| withMapState(hazelcastv1alpha1.MapPending), | |||
There was a problem hiding this comment.
@SeriyBg What about if I apply the correct configuration via the same Map CR? Will it be updated as Pending then Success?
There was a problem hiding this comment.
Yes, it will eventually go the same way as usual
hasancelik
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Impact
When MapConfig creation fails to apply, the Map status will be set to Failed