Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CN-1261]: Add static lite member support #1138

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[CN-1261]: Add static lite member support #1138

wants to merge 13 commits into from

Conversation

kutluhanmetin
Copy link
Contributor

@kutluhanmetin kutluhanmetin commented May 9, 2024 •
edited

Description

This change adds liteMemberCount field to Hazelcast CR.

User Impact

Users will be able to create lite members using Hazelcast CR's by providing liteMemberCount parameter.

@kutluhanmetin kutluhanmetin requested a review from a team as a code owner May 9, 2024 18:49
@kutluhanmetin kutluhanmetin requested review from SeriyBg and cagric0 and removed request for a team May 9, 2024 18:49
@kutluhanmetin kutluhanmetin changed the title [CN-1261]: Add static lite member support [WIP][CN-1261]: Add static lite member support May 9, 2024
@kutluhanmetin kutluhanmetin changed the title [WIP][CN-1261]: Add static lite member support [CN-1261]: Add static lite member support May 13, 2024
@kutluhanmetin kutluhanmetin added the feature Type is used to identify changes related to new backward-compatible abilities or functionality. label May 13, 2024
@kutluhanmetin kutluhanmetin added this to the 5.13.0 milestone May 13, 2024
cagric0
cagric0 suggested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@cagric0 cagric0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tiny change requests, other than that LGTM!

internal/controller/hazelcast/hazelcast_resources.go Outdated Show resolved Hide resolved
internal/controller/hazelcast/hazelcast_resources.go Outdated Show resolved Hide resolved
internal/controller/hazelcast/hazelcast_resources.go Outdated Show resolved Hide resolved
@kutluhanmetin kutluhanmetin requested review from cagric0 and hasancelik and removed request for cagric0 May 15, 2024 07:43
@github-actions GitHub Actions
Copy link

✅ All tests have passed

Total Tests 🔴 Failures 🟠 Errors ⚪ Skipped
OS 123 0 0 85
EE 123 0 0 61
Failed Tests
OS
EE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cagric0 cagric0 cagric0 requested changes

@SeriyBg SeriyBg Awaiting requested review from SeriyBg

@hasancelik hasancelik Awaiting requested review from hasancelik

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
feature Type is used to identify changes related to new backward-compatible abilities or functionality.
Projects
None yet
Milestone
5.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kutluhanmetin @SeriyBg @cagric0