Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CN-1273] Support IAM roles for service accounts in AWS #1124

Merged
merged 7 commits into from
May 31, 2024
Merged

Conversation

semihbkgr
Copy link
Member

@semihbkgr semihbkgr commented Apr 30, 2024

Description

supporting IAM roles for service accounts in AWS
see: #983

User Impact

AWS IAM roles for service accounts are supported in bucket operations

@semihbkgr semihbkgr requested a review from a team as a code owner April 30, 2024 14:30
@semihbkgr semihbkgr requested review from SeriyBg and cagric0 and removed request for a team April 30, 2024 14:30
@semihbkgr semihbkgr added the feature Type is used to identify changes related to new backward-compatible abilities or functionality. label Apr 30, 2024
@semihbkgr semihbkgr added this to the 5.12.0 milestone Apr 30, 2024
@hasancelik hasancelik requested review from hasancelik and removed request for cagric0 May 2, 2024 06:26
@hasancelik hasancelik modified the milestones: 5.12.0, 5.13.0 May 2, 2024
config/crd/bases/hazelcast.com_hazelcasts.yaml Outdated Show resolved Hide resolved
api/v1alpha1/hazelcast_types.go Outdated Show resolved Hide resolved
@@ -584,6 +584,7 @@ var _ = Describe("Hazelcast CR with Persistence feature enabled", Group("backup_
backupRestore(hazelcast, hotBackup, false)
},
Entry("using GCP Workload Identity", Tag(EE|GCP), "cn-workload-identity-test", "gs://operator-e2e-external-backup"),
Entry("using AWS IAM ServiceAccount", Tag(EE|AWS), "aws-iam-sa", "s3://operator-e2e-external-backup"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@semihbkgr semihbkgr requested a review from hasancelik May 31, 2024 13:01
Copy link

✅ All tests have passed

Total Tests 🔴 Failures 🟠 Errors ⚪ Skipped
OS 123 0 0 86
EE 123 0 0 62
Failed Tests
OS
EE

@semihbkgr semihbkgr merged commit acc59c0 into main May 31, 2024
28 checks passed
@semihbkgr semihbkgr deleted the cn-1273 branch May 31, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Type is used to identify changes related to new backward-compatible abilities or functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants