-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CN-1273] Support IAM roles for service accounts in AWS #1124
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semihbkgr
requested review from
SeriyBg and
cagric0
and removed request for
a team
April 30, 2024 14:30
semihbkgr
added
the
feature
Type is used to identify changes related to new backward-compatible abilities or functionality.
label
Apr 30, 2024
hasancelik
requested changes
May 31, 2024
.../hazelcast-platform-operator/charts/hazelcast-platform-operator-crds/templates/all-crds.yaml
Outdated
Show resolved
Hide resolved
.../hazelcast-platform-operator/charts/hazelcast-platform-operator-crds/templates/all-crds.yaml
Outdated
Show resolved
Hide resolved
@@ -584,6 +584,7 @@ var _ = Describe("Hazelcast CR with Persistence feature enabled", Group("backup_ | |||
backupRestore(hazelcast, hotBackup, false) | |||
}, | |||
Entry("using GCP Workload Identity", Tag(EE|GCP), "cn-workload-identity-test", "gs://operator-e2e-external-backup"), | |||
Entry("using AWS IAM ServiceAccount", Tag(EE|AWS), "aws-iam-sa", "s3://operator-e2e-external-backup"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This reverts commit 506b22b.
hasancelik
approved these changes
May 31, 2024
SeriyBg
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Type is used to identify changes related to new backward-compatible abilities or functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
supporting IAM roles for service accounts in AWS
see: #983
User Impact
AWS IAM roles for service accounts are supported in bucket operations