Use specific "TLSv1.2" instead of "TLS" #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
mesutcelik
approved these changes
Sep 17, 2018
|
@leszko |
|
@mesutcelik , maybe just mention in README that it uses TLS 1.2, so your JRE must support it? I would rather not list all JDKs, because then we need to kind-of support that list (add new, check all of them, etc.). Also, we never mentioned that (and |
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix hazelcast/hazelcast#13760
The issue is that certain JRE implementations don't use TLSv1.2 by default, but uses TLSv1.0 by default. An example of that is IBM Java. By being specific, all JRE which supports TLS 1.2 should work fine.
Tested on: OpenJDK, Oracle, IBM.
After merging this PR, we'll need to do 2 releases: